Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.76%. Comparing base (c133123) to head (8eb3095).

@@           Coverage Diff           @@
##             main     #821   +/-   ##
=======================================
  Coverage   39.76%   39.76%           
=======================================
  Files         114      114           
  Lines       10768    10768           
=======================================
  Hits         4282     4282           
  Misses       6087     6087           
  Partials      399      399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amarnath-ac Since we know the type of data which is []physical.PhysicalMemory, it's not necessary to use reflect. Reflect is generally used when the type is truly unknown at compile time. Instead, convert the typed slice to []interface{} at the source (in createMapInterfaceForHWInfo), which is consistent with how the other CIM types are handled. This way parseCIMResponse doesn't need to change at all.

internal\usecase\devices\wsman\message.go: line number 534

"responses": interfaceSlice(hwResults.PhysicalMemoryResult.Body.PullResponse.MemoryItems),

Add the following function to the same file

func interfaceSlice(items []physical.PhysicalMemory) []interface{} {
    result := make([]interface{}, len(items))
    for i, item := range items {
      result[i] = item
    }

	return result
}

I have tested this fix on AMT 19 and Memory Summary loads correctly. Please verify on your end as well.

@amarnath-ac Since we know the type of data which is []physical.PhysicalMemory, it's not necessary to use reflect. Reflect is generally used when the type is truly unknown at compile time. Instead, convert the typed slice to []interface{} at the source (in createMapInterfaceForHWInfo), which is consistent with how the other CIM types are handled. This way parseCIMResponse doesn't need to change at all.

internal\usecase\devices\wsman\message.go: line number 534

"responses": interfaceSlice(hwResults.PhysicalMemoryResult.Body.PullResponse.MemoryItems),

Add the following function to the same file

func interfaceSlice(items []physical.PhysicalMemory) []interface{} {
    result := make([]interface{}, len(items))
    for i, item := range items {
      result[i] = item
    }

	return result
}

I have tested this fix on AMT 19 and Memory Summary loads correctly. Please verify on your end as well.

Thanks for feedback, will update as suggested.

@amarnath-ac Since we know the type of data which is []physical.PhysicalMemory, it's not necessary to use reflect. Reflect is generally used when the type is truly unknown at compile time. Instead, convert the typed slice to []interface{} at the source (in createMapInterfaceForHWInfo), which is consistent with how the other CIM types are handled. This way parseCIMResponse doesn't need to change at all.
internal\usecase\devices\wsman\message.go: line number 534
"responses": interfaceSlice(hwResults.PhysicalMemoryResult.Body.PullResponse.MemoryItems),
Add the following function to the same file

func interfaceSlice(items []physical.PhysicalMemory) []interface{} {
    result := make([]interface{}, len(items))
    for i, item := range items {
      result[i] = item
    }

	return result
}

I have tested this fix on AMT 19 and Memory Summary loads correctly. Please verify on your end as well.

Thanks for feedback, will update as suggested.

@madhavilosetty-intel , Updated code

Hey @amarnath-ac , generallly this is the simplicity we are looking for: "responses": hwResults.PhysicalMemoryResult.Body.PullResponse.MemoryItems, , if its not useful from go-wsman-messages, then that is really where the change should be, can you take a look at fixing at the root of the problem instead of trying to convert something on top of the original conversion.

Sure, I will analyze and fix it.